[Flagship] Document the local flag store for wrangler dev - #32879
Draft
akshitsinha wants to merge 1 commit into
Draft
[Flagship] Document the local flag store for wrangler dev#32879akshitsinha wants to merge 1 commit into
akshitsinha wants to merge 1 commit into
Conversation
akshitsinha
requested review from
a team,
GregBrimble,
MattieTK,
WalshyDev,
irvinebroque,
korinne,
palashgo,
roerohan and
vy-ton
as code owners
August 20, 2026 06:56
github-actions
Bot
added
product:workers
Contributor
Review
👉 Fix in your agent 👈Fix the following review findings in PR #32879 (https://github.com/cloudflare/cloudflare-docs/pull/32879).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, follow this order:
1. Post a comment on this PR for any findings you are skipping, with the finding ID and your reasoning.
2. Then commit the fixes for the legitimate findings.
The comment must come before the commit — the bot reads PR comments when a new
push triggers a review, so skip comments posted after the push will be missed.
---
## Code Review
### Warnings (1)
#### CR-ee227d7b6682 · Undefined technical terminology
- **File:** `src/content/docs/flagship/configuration.mdx` line 104
- **Issue:** `pull` also seeds the account tag used for [percentage rollout](/flagship/targeting/percentage-rollouts/) bucketing" introduces "account tag," a term that is never defined elsewhere in the Flagship documentation and is not used by the linked percentage-rollouts page, which explains bucketing via attributes such as `targetingKey` or `userId`.
- **Fix:** Reword the sentence using documented concepts or remove the implementation detail. For example, say that `pull` copies the account-level bucketing seed so local percentage-rollout assignments match the remote app, after confirming the exact user-facing behavior with the product team.
---
## Style Guide Review
### Warnings (1)
#### SG-1708d7618285 · Do not bold program or tool names; use monospace
- **File:** `src/content/changelog/flagship/2026-08-28-local-flag-store.mdx` line 9
- **Issue:** Line adds `**[Wrangler](/workers/wrangler/)**`, bolding the Wrangler tool name
- **Fix:** Remove the bold or refer to Wrangler in plain text/link without bold formatting
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsNo convention issues found. Style Guide ReviewWarnings (1)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
github-actions
Bot
assigned
palashgo,
roerohan,
thebongy,
GregBrimble,
irvinebroque,
korinne,
MattieTK,
vy-ton and
WalshyDev
5 tasks
Flagship bindings now evaluate against a local flag store during wrangler dev instead of the remote app. The configuration page said the opposite, so replace that section with the local store workflow: pull, --local flag commands, and remote: true. Also add the Flagship binding to the Wrangler configuration reference, list it in the local development binding tables, and add a changelog entry.
akshitsinha
force-pushed
the
asinha/flagship-local-dev-docs
branch
from
August 20, 2026 07:05
bf62fea to
e6d2a45
Compare
akshitsinha
marked this pull request as draft
August 22, 2026 16:53
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the local flag store that Flagship bindings now use during
wrangler dev.The Flagship configuration page currently states the opposite of the new behaviour:
Bindings now resolve against a local, persisted store by default, so
wrangler devworks offline and local changes no longer touch production flags. Flags fall back to the default passed at the call site until the store is populated, so the pull step needs to be discoverable.Changes:
wrangler flagship flags pull,--localflag commands,remote: true, and Local Explorer.flagshipcommand page — added a--localnote, matching the existing Workflows pattern.flagshipbinding (binding,app_id,remote) to the bindings reference and the non-inheritable keys list.Implementation PR: cloudflare/workers-sdk#15268
Documentation checklist